New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18155: pg generic store: Get #6770
ROX-18155: pg generic store: Get #6770
Conversation
Images are ready for the commit at 9bdc2c7. To use with deploy scripts, first |
16b5b7d
to
a6dd70b
Compare
0eaac20
to
8228546
Compare
a6dd70b
to
390bc82
Compare
8228546
to
3a85339
Compare
390bc82
to
d6e5a0a
Compare
3a85339
to
b49fbe0
Compare
d6e5a0a
to
a315299
Compare
b49fbe0
to
54040b8
Compare
a315299
to
f501f43
Compare
54040b8
to
824a8e5
Compare
pkg/search/postgres/store.go
Outdated
if ok, err := s.permissionChecker.GetAllowed(ctx); err != nil { | ||
return nil, false, err | ||
} else if !ok { | ||
return nil, false, sac.ErrResourceAccessDenied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the behaviour compared to the generated code.
I'd stick to the previous behaviour that returns nil, false, nil
otherwise, this may leak information about the user allowed scope.
f501f43
to
c14880c
Compare
824a8e5
to
737eed5
Compare
c14880c
to
633cc54
Compare
737eed5
to
f8ee78b
Compare
633cc54
to
96d90a5
Compare
f8ee78b
to
467a72a
Compare
96d90a5
to
ffe86f7
Compare
Graphite rebased this pull request as part of a merge. |
467a72a
to
9bdc2c7
Compare
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.