Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-18155: pg generic store: GetMany #6773

Merged
merged 1 commit into from Jul 7, 2023
Merged

ROX-18155: pg generic store: GetMany #6773

merged 1 commit into from Jul 7, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 30, 2023

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@janisz janisz requested review from a team as code owners June 30, 2023 16:19
This was referenced Jun 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@janisz
Copy link
Contributor Author

janisz commented Jun 30, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Jun 30, 2023
Merged
Merged
Merged
Merged
Merged
@roxbot
Copy link
Contributor

roxbot commented Jun 30, 2023 •
edited

Images are ready for the commit at 569f2ba.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-340-g569f2ba014.

@roxbot
Copy link
Contributor

roxbot commented Jun 30, 2023

Images are ready for the commit at 42ab190.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-277-g42ab1905ad.

@janisz janisz mentioned this pull request Jun 30, 2023
Closed
5 tasks
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 6ea061a to 30d04da Compare July 3, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from 42ab190 to 91f09f5 Compare July 3, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 30d04da to 6182ccc Compare July 3, 2023 16:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from 91f09f5 to 36679e0 Compare July 3, 2023 16:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 6182ccc to 4273cef Compare July 4, 2023 13:00
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from 36679e0 to efaad61 Compare July 4, 2023 13:00
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 4273cef to 309b1a3 Compare July 4, 2023 13:57
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from efaad61 to 043cf9f Compare July 4, 2023 13:57
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 309b1a3 to 556711f Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from 043cf9f to d8a82a8 Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 556711f to 5d56899 Compare July 6, 2023 14:15
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from d8a82a8 to a55c307 Compare July 6, 2023 14:15
@janisz janisz requested a review from rhybrillou July 6, 2023 14:22
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 5d56899 to 573d29d Compare July 6, 2023 15:36
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from a55c307 to 2cffae6 Compare July 6, 2023 15:36
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

/retest

rhybrillou
rhybrillou approved these changes Jul 7, 2023
View reviewed changes
pkg/search/postgres/store.go

var sacQueryFilter *v1.Query
if s.hasPermissionsChecker() {
if ok, err := s.permissionChecker.GetAllowed(ctx); err != nil || !ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current state of existing PermissionChecker implementation, it does not make any difference, as these will check for global read access to the underlying resource(s).
Nevertheless, the generated store code was calling GetManyAllowed on the permission checker.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs branch from 573d29d to 61ff3c2 Compare July 7, 2023 12:00
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from 2cffae6 to e17c60a Compare July 7, 2023 12:00
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

/retest

Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_GetIDs to master July 7, 2023 14:19
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch from e17c60a to 569f2ba Compare July 7, 2023 14:20
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-10-operator-e2e-tests e17c60a link false /test ocp-4-10-operator-e2e-tests
ci/prow/ocp-4-10-sensor-integration-tests 569f2ba link false /test ocp-4-10-sensor-integration-tests
ci/prow/ocp-4-10-qa-e2e-tests 569f2ba link false /test ocp-4-10-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz janisz merged commit 2312b03 into master Jul 7, 2023
31 of 39 checks passed
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

@janisz merged this pull request with Graphite.

@janisz janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_GetMany branch July 7, 2023 15:32
This was referenced Jul 12, 2023
Merged
Merged
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees
No one assigned
Labels
area/central area/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janisz @roxbot @rhybrillou