chore(deps): upgrade pgx to v5 #6916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
force-pushed
the
master-janisz/07-12-chore_deps_upgrade_pgx_to_v5
branch
from
447de3e
to
e765e3b
Compare
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
from
f166fd6
to
e0240e6
Compare
|
Images are ready for the commit at 7e6aae1. To use with deploy scripts, first |
janisz
force-pushed
the
master-janisz/07-12-chore_deps_upgrade_pgx_to_v5
branch
from
e765e3b
to
3152b48
Compare
This was referenced Jul 13, 2023
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
from
e0240e6
to
ccf9ccd
Compare
This was referenced Jul 13, 2023
janisz
changed the title
janisz
force-pushed
the
master-janisz/07-12-chore_deps_upgrade_pgx_to_v5
branch
from
3152b48
to
30917ac
Compare
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
2 times, most recently
from
8acfd2c
to
1e64117
Compare
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
from
ecc8fd5
to
53233d7
Compare
|
I run benchmarks on e2-standard-8 with following command and then filter results to keep only entries that differs: BENCHTIME=1s BENCHTIMEOUT=0 BENCHCOUNT=30 nohup make go-postgres-bench-tests > results.txt &
|
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
3 times, most recently
from
0eeb37f
to
6383126
Compare
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
from
6383126
to
16315c1
Compare
|
/test |
|
@dashrews78: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test gke-scale-tests |
1 similar comment
|
/test gke-scale-tests |
dashrews78
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
This is probably a good time to tackle this. It would probably be worth having @mtodor look at it in a performance environment. (Though that may come after merge so we can incrementally fix any performance fallout)
|
I think I know why some results are worse. I've profiled Datastore test for CPU and allocations and looks like the 5.4.2 version has a regression in copy from method that allocates more memory then old version. Update to 5.5.0 resolves this issue.
|
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
force-pushed
the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
from
3cccb20
to
7e6aae1
Compare
|
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
connorgorman
approved these changes
Nov 7, 2023
|
Bench results after upgrading to 5.5 looks better. Still there is a room for improvements but it's not that bad. |
janisz
deleted the
master-janisz/07-12-chore_deps_copy_code_from_unmatinained_dep
branch
ksurabhi91
pushed a commit
that referenced
this pull request
Nov 28, 2023
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
Important changes in v5:
CommandTagis a type[]TextArraybut now it's just a[]stringso only filtering part is needed.'null'but now it'snullso I added a change to use{}withpgutils.EmptyOrMapSince https://github.com/driftprogramming/pgxpoolmock is not maintained over the last year and does not have pgx v5 support I decide to copy mocker rows file to our repo and clean it up from unused functions.
Checklist
If any of these don't apply, please comment below.
Testing Performed
CI