Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pg): preallocate memory when copy #6894

Merged
merged 1 commit into from Jul 14, 2023
Merged

refactor(pg): preallocate memory when copy #6894

merged 1 commit into from Jul 14, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jul 11, 2023 •
edited

Description

During copy we could preallocate memory to not have to reallocate it when we add objects to copy. The same applies for delete ids slice.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

@janisz janisz requested review from a team as code owners July 11, 2023 12:33
@janisz janisz requested a review from rhybrillou July 11, 2023 12:39
@roxbot
Copy link
Contributor

roxbot commented Jul 11, 2023 •
edited

Images are ready for the commit at cc3069c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-402-gcc3069c3b0.

@janisz janisz force-pushed the master-janisz/07-10-ROX-18155_pg_generic_store_Upsert branch from cec2bcc to f943032 Compare July 12, 2023 11:03
@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from eefca71 to 74a96e6 Compare July 12, 2023 11:03
This was referenced Jul 12, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@janisz
Copy link
Contributor Author

janisz commented Jul 12, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@janisz janisz mentioned this pull request Jul 12, 2023
Merged
5 tasks
@janisz janisz force-pushed the master-janisz/07-10-ROX-18155_pg_generic_store_Upsert branch from f943032 to 5e857e5 Compare July 12, 2023 16:56
@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from 74a96e6 to 6a9daa9 Compare July 12, 2023 16:57
@janisz janisz force-pushed the master-janisz/07-10-ROX-18155_pg_generic_store_Upsert branch from 5e857e5 to f9f38c6 Compare July 12, 2023 16:59
@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from 6a9daa9 to 131957e Compare July 12, 2023 16:59
@janisz janisz force-pushed the master-janisz/07-10-ROX-18155_pg_generic_store_Upsert branch from f9f38c6 to 8f100c9 Compare July 13, 2023 10:32
This was referenced Jul 13, 2023
Closed
Merged
rhybrillou
rhybrillou reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@rhybrillou rhybrillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks ok, but in the current state of the PR, there are changes from #6881 and #6882 polluting the review. Could you please re-stack ?

Base automatically changed from master-janisz/07-10-ROX-18155_pg_generic_store_Upsert to master July 13, 2023 16:39
@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from 131957e to cc3069c Compare July 13, 2023 16:42
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

@rhybrillou My bad, forgot to re-stack after merging other PRs. It's fixed now

@janisz janisz requested review from rhybrillou and a team July 13, 2023 16:50
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-13-operator-e2e-tests 131957e link false /test ocp-4-13-operator-e2e-tests
ci/prow/ocp-4-13-qa-e2e-tests 131957e link false /test ocp-4-13-qa-e2e-tests
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests 131957e link false /test ocp-4-13-core-bpf-qa-e2e-tests
ci/prow/gke-qa-e2e-tests cc3069c link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
Copy link
Contributor Author

janisz commented Jul 14, 2023

/retest

@janisz janisz merged commit 1240370 into master Jul 14, 2023
32 of 33 checks passed
@janisz janisz deleted the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch July 14, 2023 12:00
@janisz
Copy link
Contributor Author

janisz commented Jul 14, 2023

@janisz merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees
No one assigned
Labels
area/central area/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janisz @roxbot @rhybrillou