Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-18155: pg generic store: GetByQuery #6771

Merged
merged 1 commit into from Jul 7, 2023
Merged

ROX-18155: pg generic store: GetByQuery #6771

merged 1 commit into from Jul 7, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 30, 2023

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@janisz janisz requested a review from a team as a code owner June 30, 2023 16:19
This was referenced Jun 30, 2023
Merged
Merged
Merged
Merged
Merged
@janisz
Copy link
Contributor Author

janisz commented Jun 30, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@janisz janisz mentioned this pull request Jun 30, 2023
Merged
5 tasks
This was referenced Jun 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@roxbot
Copy link
Contributor

roxbot commented Jun 30, 2023 •
edited

Images are ready for the commit at fb1f5d0.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-336-gfb1f5d08ce.

@janisz janisz mentioned this pull request Jun 30, 2023
Closed
5 tasks
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 0eaac20 to 8228546 Compare July 3, 2023 15:47
@janisz janisz requested a review from a team as a code owner July 3, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 2975cf0 to 48788ec Compare July 3, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 8228546 to 3a85339 Compare July 3, 2023 16:01
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 48788ec to 8ff2fcb Compare July 3, 2023 16:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 3a85339 to b49fbe0 Compare July 4, 2023 12:59
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 8ff2fcb to 2a14858 Compare July 4, 2023 12:59
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from b49fbe0 to 54040b8 Compare July 4, 2023 13:22
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 2a14858 to 387ba5f Compare July 4, 2023 13:22
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 54040b8 to 824a8e5 Compare July 4, 2023 13:57
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 387ba5f to 6fb7695 Compare July 4, 2023 13:57
rhybrillou
rhybrillou reviewed Jul 5, 2023
View reviewed changes
pkg/search/postgres/store.go Outdated Show resolved Hide resolved
pkg/search/postgres/store.go Show resolved Hide resolved
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 824a8e5 to 737eed5 Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 6fb7695 to 2db5911 Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 737eed5 to f8ee78b Compare July 6, 2023 14:15
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 2db5911 to ba81a0e Compare July 6, 2023 14:15
@janisz janisz requested a review from rhybrillou July 6, 2023 14:21
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from f8ee78b to 467a72a Compare July 6, 2023 15:36
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from ba81a0e to 8dbe742 Compare July 6, 2023 15:36
rhybrillou
rhybrillou approved these changes Jul 6, 2023
View reviewed changes
pkg/search/postgres/store.go

var sacQueryFilter *v1.Query
if s.hasPermissionsChecker() {
if ok, err := s.permissionChecker.GetAllowed(ctx); err != nil || !ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current state of existing PermissionChecker implementation, it does not make any difference, as these will check for global read access to the underlying resource(s).
Nevertheless, the generated store code was calling GetManyAllowed on the permission checker.

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests 8dbe742 link false /test ocp-4-13-core-bpf-qa-e2e-tests
ci/prow/ocp-4-13-qa-e2e-tests 8dbe742 link false /test ocp-4-13-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

@janisz started a stack merge that includes this pull request via Graphite.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Get branch from 467a72a to 9bdc2c7 Compare July 7, 2023 09:20
Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_Get to master July 7, 2023 10:17
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

Graphite rebased this pull request as part of a merge.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch from 8dbe742 to fb1f5d0 Compare July 7, 2023 10:17
@janisz janisz merged commit 98fbb81 into master Jul 7, 2023
32 of 39 checks passed
@janisz janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_GetByQuery branch July 7, 2023 11:25
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

@janisz merged this pull request with Graphite.

This was referenced Jul 12, 2023
Merged
Merged
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees
No one assigned
Labels
area/central area/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janisz @roxbot @rhybrillou