Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18155: pg generic store: cleanup #6778

Merged
merged 2 commits into from Jul 13, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 30, 2023

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@roxbot
Copy link
Contributor

roxbot commented Jun 30, 2023

Images are ready for the commit at 2f6a491.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-391-g2f6a491fb1.

@janisz janisz mentioned this pull request Jun 30, 2023
5 tasks
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 3a613cd to e76f62d Compare July 3, 2023 15:48
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from c3d8279 to 4f44b1e Compare July 3, 2023 15:48
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e76f62d to 8916579 Compare July 3, 2023 16:03
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 4f44b1e to 111f302 Compare July 3, 2023 16:03
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch 2 times, most recently from a29ea41 to d115aa9 Compare July 4, 2023 13:58
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 111f302 to a70ff73 Compare July 4, 2023 13:58
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from d115aa9 to 7c359f9 Compare July 6, 2023 11:03
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from a70ff73 to e5e1c14 Compare July 6, 2023 11:03
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 7c359f9 to 76663e1 Compare July 6, 2023 14:16
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from e5e1c14 to 64188c7 Compare July 6, 2023 14:16
@janisz janisz requested a review from rhybrillou July 6, 2023 14:21
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 76663e1 to 79fc605 Compare July 6, 2023 15:37
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 64188c7 to b3720a4 Compare July 6, 2023 15:37
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 79fc605 to e99a02f Compare July 6, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from b3720a4 to 047a6ff Compare July 6, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e99a02f to e0a2cc6 Compare July 6, 2023 16:34
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 047a6ff to 5eabc67 Compare July 6, 2023 16:34
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from e0a2cc6 to 0f63931 Compare July 7, 2023 12:01
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 5eabc67 to 16f8520 Compare July 7, 2023 12:01
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_regions branch from 0f63931 to 93c68e3 Compare July 10, 2023 08:11
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 16f8520 to 02148b4 Compare July 10, 2023 08:12
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

@janisz started a stack merge that includes this pull request via Graphite.

Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_regions to master July 13, 2023 07:30
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

Graphite rebased this pull request as part of a merge.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 3303ebe to 2f6a491 Compare July 13, 2023 07:31
@janisz janisz merged commit b4c6b8a into master Jul 13, 2023
32 of 33 checks passed
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

@janisz merged this pull request with Graphite.

@janisz janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch July 13, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants