ROX-18155: pg generic store: GetAll

stackrox · Jul 3, 2023 · a6dd70b · a6dd70b
1 parent c1557dc
commit a6dd70b
Show file tree

Hide file tree

Showing 14 changed files with 12 additions and 159 deletions.
diff --git a/central/authprovider/datastore/internal/store/postgres/store.go b/central/authprovider/datastore/internal/store/postgres/store.go
diff --git a/central/externalbackups/internal/store/postgres/store.go b/central/externalbackups/internal/store/postgres/store.go
diff --git a/central/group/datastore/internal/store/postgres/store.go b/central/group/datastore/internal/store/postgres/store.go
diff --git a/central/imageintegration/store/postgres/store.go b/central/imageintegration/store/postgres/store.go
diff --git a/central/logimbue/store/postgres/store.go b/central/logimbue/store/postgres/store.go
diff --git a/central/notifier/datastore/internal/store/postgres/store.go b/central/notifier/datastore/internal/store/postgres/store.go
diff --git a/central/policy/store/postgres/store.go b/central/policy/store/postgres/store.go
diff --git a/central/policycategory/store/postgres/store.go b/central/policycategory/store/postgres/store.go
diff --git a/central/policycategoryedge/store/postgres/store.go b/central/policycategoryedge/store/postgres/store.go
diff --git a/central/serviceidentities/internal/store/postgres/store.go b/central/serviceidentities/internal/store/postgres/store.go
diff --git a/pkg/search/postgres/store.go b/pkg/search/postgres/store.go
@@ -179,3 +179,15 @@ func (s *GenericStore[T, PT]) Walk(ctx context.Context, fn func(obj PT) error) e
 	}
 	return nil
 }
+
+// GetAll retrieves all objects from the store.
+func (s *GenericStore[T, PT]) GetAll(ctx context.Context) ([]*T, error) {
+	defer s.setPostgresOperationDurationTime(time.Now(), ops.GetAll)
+
+	var objs []*T
+	err := s.Walk(ctx, func(obj PT) error {
+		objs = append(objs, (*T)(obj))
+		return nil
+	})
+	return objs, err
+}
diff --git a/tools/generate-helpers/pg-table-bindings/store.go.tpl b/tools/generate-helpers/pg-table-bindings/store.go.tpl
@@ -728,21 +728,6 @@ func (s *storeImpl) GetIDs(ctx context.Context) ([]{{$singlePK.Type}}, error) {
 }
 {{- end }}
 
-{{- if .GetAll }}
-
-// GetAll retrieves all objects from the store.
-func(s *storeImpl) GetAll(ctx context.Context) ([]*{{.Type}}, error) {
-	defer metrics.SetPostgresOperationDurationTime(time.Now(), ops.GetAll, "{{.TrimmedType}}")
-
-    var objs []*{{.Type}}
-    err := s.Walk(ctx, func(obj *{{.Type}}) error {
-        objs = append(objs, obj)
-        return nil
-    })
-    return objs, err
-}
-{{- end}}
-
 //// Interface functions - END
 
 //// Used for testing

diff --git a/tools/generate-helpers/pg-table-bindings/test/postgres/store.go b/tools/generate-helpers/pg-table-bindings/test/postgres/store.go
diff --git a/tools/generate-helpers/pg-table-bindings/testuuidkey/postgres/store.go b/tools/generate-helpers/pg-table-bindings/testuuidkey/postgres/store.go