Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pg): remove blank lines #6881

Merged
merged 1 commit into from Jul 13, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jul 10, 2023

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@roxbot
Copy link
Contributor

roxbot commented Jul 10, 2023

Images are ready for the commit at 33d8992.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-392-g33d8992cee.

@janisz
Copy link
Contributor Author

janisz commented Jul 11, 2023

/retest

@janisz janisz requested a review from rhybrillou July 11, 2023 10:08
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 02148b4 to 3303ebe Compare July 12, 2023 16:59
@janisz janisz force-pushed the master-janisz/07-10-refactor_pg_remove_blank_lines branch from 7215e6a to bc74488 Compare July 12, 2023 16:59
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

@janisz started a stack merge that includes this pull request via Graphite.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_cleanup branch from 3303ebe to 2f6a491 Compare July 13, 2023 07:31
Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_cleanup to master July 13, 2023 08:40
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

Graphite rebased this pull request as part of a merge.

@janisz janisz force-pushed the master-janisz/07-10-refactor_pg_remove_blank_lines branch from bc74488 to 33d8992 Compare July 13, 2023 08:40
@janisz janisz merged commit d18d988 into master Jul 13, 2023
31 of 33 checks passed
@janisz janisz deleted the master-janisz/07-10-refactor_pg_remove_blank_lines branch July 13, 2023 09:38
@janisz
Copy link
Contributor Author

janisz commented Jul 13, 2023

@janisz merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants