New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18155: pg generic store: regions #6777
ROX-18155: pg generic store: regions #6777
Conversation
Images are ready for the commit at dab7621. To use with deploy scripts, first |
824f44b
to
f1a9c46
Compare
3a613cd
to
e76f62d
Compare
f1a9c46
to
9d57793
Compare
e76f62d
to
8916579
Compare
9d57793
to
bd89a22
Compare
8916579
to
a29ea41
Compare
bd89a22
to
fb26e10
Compare
a29ea41
to
d115aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the changes that are showing here should not actually be part of this PR.
Please make sure that the only changes here are those linked to the use of regions in the store template and in the generated files.
fb26e10
to
c7cc82f
Compare
d115aa9
to
7c359f9
Compare
c7cc82f
to
45a3aeb
Compare
7c359f9
to
76663e1
Compare
45a3aeb
to
b623261
Compare
76663e1
to
79fc605
Compare
b623261
to
889ba77
Compare
e99a02f
to
e0a2cc6
Compare
889ba77
to
7e60fa5
Compare
e0a2cc6
to
0f63931
Compare
7e60fa5
to
8dde6f5
Compare
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
0f63931
to
93c68e3
Compare
93c68e3
to
dab7621
Compare
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.