Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18155: pg generic store: DeleteMany #6776

Merged

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 30, 2023

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@roxbot
Copy link
Contributor

roxbot commented Jun 30, 2023

Images are ready for the commit at 8dde6f5.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-345-g8dde6f5abb.

@janisz janisz mentioned this pull request Jun 30, 2023
5 tasks
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 83e4aeb to 6b92e68 Compare July 3, 2023 15:48
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 824f44b to f1a9c46 Compare July 3, 2023 15:48
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 6b92e68 to a9a6a17 Compare July 3, 2023 16:03
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from f1a9c46 to 9d57793 Compare July 3, 2023 16:03
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from a9a6a17 to 514173e Compare July 4, 2023 13:00
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 9d57793 to bd89a22 Compare July 4, 2023 13:00
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 514173e to c91757f Compare July 4, 2023 13:58
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from bd89a22 to fb26e10 Compare July 4, 2023 13:58
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from c91757f to d4aaeaa Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from fb26e10 to c7cc82f Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from d4aaeaa to 1a63804 Compare July 6, 2023 14:16
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from c7cc82f to 45a3aeb Compare July 6, 2023 14:16
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 1a63804 to 5c5489f Compare July 6, 2023 15:36
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 45a3aeb to b623261 Compare July 6, 2023 15:37
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 5c5489f to 08f1a51 Compare July 6, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from b623261 to 889ba77 Compare July 6, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 08f1a51 to 9faa773 Compare July 7, 2023 12:00
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 889ba77 to 7e60fa5 Compare July 7, 2023 12:01
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Delete branch from 9faa773 to f124f77 Compare July 7, 2023 17:33
Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_Delete to master July 7, 2023 19:24
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch from 7e60fa5 to 8dde6f5 Compare July 7, 2023 19:25
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-13-operator-e2e-tests 7e60fa5 link false /test ocp-4-13-operator-e2e-tests
ci/prow/gke-qa-e2e-tests 7e60fa5 link false /test gke-qa-e2e-tests
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests 7e60fa5 link false /test ocp-4-13-core-bpf-qa-e2e-tests
ci/prow/ocp-4-10-qa-e2e-tests 8dde6f5 link false /test ocp-4-10-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz janisz merged commit 7387236 into master Jul 7, 2023
34 of 39 checks passed
@janisz janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_DeleteMany branch July 7, 2023 20:54
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

@janisz merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants