Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18155: pg generic store: Walk #6768

Merged
merged 1 commit into from Jul 7, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 30, 2023

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@roxbot
Copy link
Contributor

roxbot commented Jun 30, 2023

Images are ready for the commit at 53be42e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-315-g53be42e898.

@janisz janisz mentioned this pull request Jun 30, 2023
5 tasks
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Count branch from 13c3653 to 9a3c949 Compare July 3, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from 6ec3701 to c1557dc Compare July 3, 2023 15:47
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Count branch from 9a3c949 to 8381710 Compare July 3, 2023 16:01
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from c1557dc to 29b04c2 Compare July 3, 2023 16:01
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Count branch from 8381710 to 6c683d4 Compare July 4, 2023 12:59
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from 29b04c2 to 5fb855e Compare July 4, 2023 12:59
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Count branch from 6c683d4 to 6fff946 Compare July 4, 2023 13:22
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch 2 times, most recently from fe331f0 to d78d2af Compare July 4, 2023 13:57
pkg/search/postgres/store.go Outdated Show resolved Hide resolved
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Count branch from 6fff946 to 3a3da58 Compare July 6, 2023 09:58
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Count branch from 3a3da58 to a994e5b Compare July 6, 2023 11:02
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from d78d2af to ad19111 Compare July 6, 2023 11:02
Base automatically changed from master-janisz/06-30-ROX-18155_pg_generic_store_Count to master July 6, 2023 12:11
@janisz janisz force-pushed the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch from ad19111 to 53be42e Compare July 6, 2023 14:15
@janisz janisz requested a review from rhybrillou July 6, 2023 14:21
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-10-qa-e2e-tests 53be42e link false /test ocp-4-10-qa-e2e-tests
ci/prow/ocp-4-13-qa-e2e-tests 53be42e link false /test ocp-4-13-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

@janisz started a stack merge that includes this pull request via Graphite.

@janisz janisz merged commit 7b42f0e into master Jul 7, 2023
37 of 39 checks passed
@janisz janisz deleted the master-janisz/06-30-ROX-18155_pg_generic_store_Walk branch July 7, 2023 08:07
@janisz
Copy link
Contributor Author

janisz commented Jul 7, 2023

@janisz merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants