New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18155: pg generic store: Delete #6775
ROX-18155: pg generic store: Delete #6775
Conversation
Images are ready for the commit at f124f77. To use with deploy scripts, first |
45ea17e
to
6766f93
Compare
83e4aeb
to
6b92e68
Compare
6766f93
to
2e100d1
Compare
6b92e68
to
a9a6a17
Compare
2e100d1
to
ddfc8a1
Compare
a9a6a17
to
514173e
Compare
ddfc8a1
to
3f6dff3
Compare
514173e
to
c91757f
Compare
func (s *GenericStore[T, PT]) Delete(ctx context.Context, id string) error { | ||
q := search.NewQueryBuilder().AddDocIDs(id).ProtoQuery() | ||
return s.DeleteByQuery(ctx, q) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simplification and code reduction :o)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand it prevents us from tracking simple queries from complicated ones
3f6dff3
to
f8c2863
Compare
c91757f
to
d4aaeaa
Compare
f8c2863
to
8eda922
Compare
d4aaeaa
to
1a63804
Compare
8eda922
to
c9fa819
Compare
1a63804
to
5c5489f
Compare
c9fa819
to
182c002
Compare
5c5489f
to
08f1a51
Compare
182c002
to
67da9dd
Compare
08f1a51
to
9faa773
Compare
67da9dd
to
fb141f1
Compare
Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready. |
9faa773
to
f124f77
Compare
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.