Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18391: cleanup permission checker #6907

Merged

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jul 12, 2023

Description

When we started PG migration project we were unsure in what direction it will go with permission checker. This resulted in a safe approach to support everything we could think of. After time we can cleanup permission checker interface and limit it to only two methods.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

@roxbot
Copy link
Contributor

roxbot commented Jul 12, 2023

Images are ready for the commit at 0b3db22.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-412-g0b3db2286f.

@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from 74a96e6 to 6a9daa9 Compare July 12, 2023 16:57
@janisz janisz requested a review from a team as a code owner July 12, 2023 16:57
@janisz janisz force-pushed the master-janisz/07-12-ROX-18391_cleanup_permission_checker branch from 8445654 to 53b2395 Compare July 12, 2023 16:57
@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from 6a9daa9 to 131957e Compare July 12, 2023 16:59
@janisz janisz force-pushed the master-janisz/07-12-ROX-18391_cleanup_permission_checker branch from 53b2395 to ea224a8 Compare July 12, 2023 16:59
@janisz janisz requested a review from rhybrillou July 13, 2023 10:34
@janisz janisz force-pushed the master-janisz/07-11-refactor_pg_preallocate_memory_when_copy branch from 131957e to cc3069c Compare July 13, 2023 16:42
@janisz janisz force-pushed the master-janisz/07-12-ROX-18391_cleanup_permission_checker branch from ea224a8 to aede067 Compare July 13, 2023 16:42
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests aede067 link false /test gke-qa-e2e-tests
ci/prow/ocp-4-10-qa-e2e-tests aede067 link false /test ocp-4-10-qa-e2e-tests
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests aede067 link false /test ocp-4-13-core-bpf-qa-e2e-tests
ci/prow/ocp-4-13-qa-e2e-tests aede067 link false /test ocp-4-13-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
Copy link
Contributor Author

janisz commented Jul 14, 2023

/retest

Base automatically changed from master-janisz/07-11-refactor_pg_preallocate_memory_when_copy to master July 14, 2023 12:00
@janisz
Copy link
Contributor Author

janisz commented Jul 14, 2023

Graphite rebased this pull request as part of a merge.

@janisz janisz force-pushed the master-janisz/07-12-ROX-18391_cleanup_permission_checker branch from aede067 to 0b3db22 Compare July 14, 2023 12:01
@janisz janisz merged commit 286a940 into master Jul 14, 2023
32 of 39 checks passed
@janisz janisz deleted the master-janisz/07-12-ROX-18391_cleanup_permission_checker branch July 14, 2023 12:57
@janisz
Copy link
Contributor Author

janisz commented Jul 14, 2023

@janisz merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants