Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all types problems #4496

Closed
hudochenkov opened this issue Dec 28, 2019 · 7 comments · Fixed by #5878
Closed

Fix all types problems #4496

hudochenkov opened this issue Dec 28, 2019 · 7 comments · Fixed by #5878
Labels
status: ready to implement is ready to be worked on by someone type: refactor an improvement to the code structure

Comments

@hudochenkov
Copy link
Member

During migration from Flow to TypeScript (#4245) we marked many places with @ts-ignore comments. We need to remove all these comments and fix types problems, which were suppressed by these comments.
@hudochenkov hudochenkov added the type: refactor an improvement to the code structure label Dec 28, 2019
@jeddy3 jeddy3 added the status: ready to implement is ready to be worked on by someone label Jan 11, 2020
@ybiquitous
Copy link
Member

Now I'm addressing a new type package @types/postcss-less. If you are interested, please take a look: 😉

DefinitelyTyped/DefinitelyTyped#46235

If @types/postcss-less is published, we can fix the following declaration and some @ts-ignore comments:

stylelint/types/global.d.ts

Line 5 in cecacb9

declare module 'postcss-less';

stylelint/lib/utils/isLessVariable.js

Lines 10 to 11 in cecacb9

// @ts-ignore TODO TYPES LESS property variable does not exists in types
return (atRule.type === 'atrule' && atRule.variable && !hasBlock(atRule)) || false;

@ybiquitous ybiquitous mentioned this issue Jul 24, 2020
Merged
@ybiquitous ybiquitous mentioned this issue Sep 2, 2020
Merged
jeddy3 pushed a commit that referenced this issue Sep 13, 2020
@ybiquitous
Add @types/postcss-less (#4920)
528c06d 
This is a part of #4496 and improves type-checking about LESS. (fixing `// @ts-ignore`)

https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/postcss-less
ybiquitous added a commit that referenced this issue Jun 8, 2021
@ybiquitous
Refactor to more specific function types
ae62dad 
This refactoring makes abstract function types more specific, such as just `Function`.
I believe this will help code changes for ESM.

A part of #4496
@ybiquitous ybiquitous mentioned this issue Jun 8, 2021
Merged
jeddy3 pushed a commit that referenced this issue Jun 8, 2021
@ybiquitous
Refactor to more specific function types (#5363)
54e4165 
This refactoring makes abstract function types more specific, such as just `Function`.
I believe this will help code changes for ESM.

A part of #4496
@ybiquitous ybiquitous mentioned this issue Jun 9, 2021
Merged
This was referenced Jul 16, 2021
Merged
Merged
Merged
@ybiquitous ybiquitous mentioned this issue Jul 27, 2021
Merged
This was referenced Aug 11, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 18, 2021
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Sep 2, 2021
Merged
Merged
Merged
Merged
@ybiquitous ybiquitous mentioned this issue Sep 4, 2021
Merged
@ybiquitous
Copy link
Member

ybiquitous commented Sep 14, 2021 •
edited

Here is a list of files using the // @ts-nocheck comment.

This is created by the following command:

git grep -l '@ts-nocheck' | sed -r 's/^(.+)/- [ ] `\1`/'

@jeddy3
Copy link
Member

jeddy3 commented Sep 14, 2021

You've made an amazing amount of progress improving the type coverage over the last couple of months!

This was referenced Sep 14, 2021
Merged
Merged
Merged
This was referenced Sep 22, 2021
Merged
Merged
@ybiquitous
Copy link
Member

Related to #5580

@ybiquitous ybiquitous mentioned this issue Oct 24, 2021
Merged
This was referenced Nov 7, 2021
Merged
Merged
@ybiquitous ybiquitous mentioned this issue Dec 9, 2021
Merged
This was referenced Jan 11, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 19, 2022
Merged
Merged
Merged
This was referenced Feb 3, 2022
Merged
Merged
Merged
@ybiquitous
Copy link
Member

#5878 is the last one PR!

@jeddy3
Copy link
Member

jeddy3 commented Feb 4, 2022

@ybiquitous Many thanks again for completing this huge endeavour!

@ybiquitous
Copy link
Member

@jeddy3 Without your support, I wouldn't have been able to stay motivated. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ready to implement is ready to be worked on by someone type: refactor an improvement to the code structure
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to fix all type problems stylelint/stylelint
3 participants
@ybiquitous @hudochenkov @jeddy3