Refactor to improve types for declaration-* rules
#5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes `// @ts-nocheck` from the remaining `declaration-*` rules. Also, this adds 2 type parameters to the `StylelintRule` type to pass the type-check.
ybiquitous
force-pushed
the
refactor-types-for-declaration-rules
branch
from
23a3c30
to
dddf856
Compare
ybiquitous
commented
Aug 18, 2021
| secondaryOptions: Record<string, any>, | ||
| export type StylelintRule<P = any, S = any> = (( | ||
| primaryOption: P, | ||
| secondaryOptions: Record<string, S>, |
There was a problem hiding this comment.
[note] P - Primary, S - Secondary
There was a problem hiding this comment.
Why do not use full words? 😄
There was a problem hiding this comment.
I follow the existing style, but is using full words common? (I'm open to change)
stylelint/types/stylelint/index.d.ts
Line 12 in dddf856
stylelint/types/stylelint/index.d.ts
Line 51 in dddf856
There was a problem hiding this comment.
Let's follow the existing style. We can revisit the lot if it becomes an issue.
ybiquitous
commented
Aug 18, 2021
jeddy3
approved these changes
Aug 18, 2021
| secondaryOptions: Record<string, any>, | ||
| export type StylelintRule<P = any, S = any> = (( | ||
| primaryOption: P, | ||
| secondaryOptions: Record<string, S>, |
There was a problem hiding this comment.
Let's follow the existing style. We can revisit the lot if it becomes an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4496
This change removes
// @ts-nocheckfrom the remainingdeclaration-*rules.Also, this adds 2 type parameters to the
StylelintRuletype to pass the type-check.