Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to improve types for function-* rules #5487

Merged
merged 3 commits into from Aug 20, 2021
Merged

Refactor to improve types for function-* rules #5487

merged 3 commits into from Aug 20, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #4496

Is there anything in the PR that needs further explanation?

This change removes // @ts-nocheck from the function-* rules.

@ybiquitous
Refactor to improve types for function-* rules
7b29287 
This change removes `// @ts-nocheck` from the `function-*` rules.
@ybiquitous ybiquitous marked this pull request as ready for review August 19, 2021 15:59
jeddy3
jeddy3 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. You're making a lot of progress through the rules!

@ybiquitous ybiquitous mentioned this pull request Aug 20, 2021
Merged
@ybiquitous ybiquitous merged commit c0b1773 into v14 Aug 20, 2021
@ybiquitous ybiquitous deleted the refactor-types-for-function-rules branch August 20, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3