Refactor to improve types for max-* rules
#5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes `// @ts-nocheck` from the `max-*` rules.
To-do
|
jeddy3
approved these changes
Sep 2, 2021
| @@ -67,18 +64,19 @@ function rule(max, options, context) { | |||
| const rootRawsAfter = root.raws.after; | |||
|
|
|||
| // not document node | |||
| // @ts-expect-error -- TS2339: Property 'document' does not exist on type 'Root'. | |||
There was a problem hiding this comment.
We'll likely need to revisit this document stuff at some point in light of postcss/postcss#1582.
I think it's mainly the max whitespace rules that touch it.
There was a problem hiding this comment.
Yes, I also think so. 👍🏼
I didn't know how I should handle it, so I've left // @ts-expect-error comments.
There was a problem hiding this comment.
Leaving // @ts-expect-error comments was the right thing to do.
Feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4496
This change removes
// @ts-nocheckfrom themax-*rules.