Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to improve types for rule-empty-line-before rule #5834

Merged
merged 1 commit into from Jan 17, 2022
Merged

Refactor to improve types for rule-empty-line-before rule #5834

merged 1 commit into from Jan 17, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #4496

Is there anything in the PR that needs further explanation?

  • Remove // @ts-nocheck to enable type-checking.
  • Improve the code a bit for type safety.

@ybiquitous
Copy link
Member Author

Added line #L118 was not covered by tests

I think it is ignorable.

@ybiquitous ybiquitous mentioned this pull request Jan 14, 2022
Closed
jeddy3
jeddy3 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ybiquitous ybiquitous merged commit 7af4b10 into main Jan 17, 2022
@ybiquitous ybiquitous deleted the refactor-rule-empty-line-before branch January 17, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3