Refactor to improve types for some rules #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes `// @ts-nocheck` from the following rules: - `keyframe-declaration-no-important` - `keyframes-name-pattern` - `length-zero-no-unit` - `linebreaks`
ybiquitous
commented
Aug 25, 2021
| function reportNewlineError(line, column) { | ||
| // Creating a node manually helps us to point to empty lines. | ||
| const node = postcss.rule({ | ||
| source: { | ||
| start: { line, column }, | ||
| start: { line, column, offset: 0 }, | ||
| input: new postcss.Input(''), |
There was a problem hiding this comment.
I think it's acceptable. We can always revisit.
ybiquitous
commented
Aug 25, 2021
|
|
||
| if (context.fix) { | ||
| const propertiesToUpdate = ['selector', 'value', 'text']; | ||
| const rawsPropertiesToUpdate = ['before', 'after']; |
There was a problem hiding this comment.
[note] This is a more type-safe way, so that the property sets are unnecessary.
jeddy3
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Fantastic, thanks!
The @param above functions adds so much clarity, especially when destructuring is being used, e.g.:
/**
* @param {import('postcss').Declaration} decl
* @param {import('postcss-value-parser').Node[]} nodes
* @param {number} index
*/
function isLineHeightValue({ prop }, nodes, index) { .. }
|
@jeddy3 I always appreciate your review! The progress is almost 50%: 😃 $ ls -l lib/rules | wc -l
201
$ git grep -l '@ts-nocheck' -- lib | wc -l
109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4496
This change removes
// @ts-nocheckfrom the following rules:keyframe-declaration-no-importantkeyframes-name-patternlength-zero-no-unitlinebreaks