Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to improve types for media-feature-* rules #5511

Merged
merged 1 commit into from Sep 5, 2021
Merged

Refactor to improve types for media-feature-* rules #5511

merged 1 commit into from Sep 5, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #4496

Is there anything in the PR that needs further explanation?

This change removes // @ts-nocheck from the media-feature-* rules.

@ybiquitous
Refactor to improve types for media-feature-* rules
582a24a 
This change removes `// @ts-nocheck` from the `media-feature-*` rules.
jeddy3
jeddy3 approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM thanks!

You must be at least over halfway through the rules by now? Many thanks again for this all refactoring work!

@ybiquitous
Copy link
Member Author

ybiquitous commented Sep 5, 2021 •
edited

@jeddy3 Thanks a lot for your quick review! 😄

Yes, we're roughly halfway there.

$ git grep -l '@ts-nocheck' lib/rules | wc -l
      87

$ ls -l lib/rules | wc -l
     201

@ybiquitous ybiquitous merged commit 44889a5 into v14 Sep 5, 2021
@ybiquitous ybiquitous deleted the refactor-types-for-media-feature-rules branch September 5, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3