Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to improve types for named-grid-areas-no-invalid rule #5513

Merged
merged 1 commit into from Sep 5, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #4496

Is there anything in the PR that needs further explanation?

This change removes // @ts-nocheck from the named-grid-areas-no-invalid rule.

This change removes `// @ts-nocheck` from the `named-grid-areas-no-invalid` rule.
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.


Incidentally, we should probably apply this rule to the grid and grid-template shorthands. I'll create an issue for it. I've been using the shorthands recently and they're great for combining areas with explicit row/column sizes, e.g.:

a {
  grid-template:
    "a a" 1fr
    "b b" 1rem
    / 1fr max-content;
}

@ybiquitous
Copy link
Member Author

@jeddy3 Thanks for the review and nice suggestion about grid-template shorthand! I agree with the suggestion. 👍🏼

@ybiquitous ybiquitous merged commit c1713ea into v14 Sep 5, 2021
@ybiquitous ybiquitous deleted the refactor-types-for-named-grid-rule branch September 5, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants