Refactor to improve types for block-* rules
#5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes `// @ts-nocheck` from the `block-*` rules. In addition, it improves the types of some utilities.
ybiquitous
commented
Jul 27, 2021
| if (!hasBlock(statement)) { | ||
| return false; | ||
| return ''; |
There was a problem hiding this comment.
[note] I don't know why this function has returned a boolean, but it seems to make sense that it returns a string instead.
For example, it appears returning a boolean is incorrect at the following place, but errors never occur.
Perhaps, it has no problems because of calling hasBlock() before blockString().
jeddy3
approved these changes
Jul 27, 2021
jeddy3
changed the title
block-* rulesblock-* rules
|
@jeddy3 Thank you so much for the quick review! 😄 |
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4496
(see also #5418)
This change removes
// @ts-nocheckfrom theblock-*rules.In addition, it improves the types of some utilities.