Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to improve types for no-duplicate-* rules #5543

Merged
merged 1 commit into from Sep 17, 2021
Merged

Refactor to improve types for no-duplicate-* rules #5543

merged 1 commit into from Sep 17, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #4496

Is there anything in the PR that needs further explanation?

This change removes // @ts-nocheck from the no-duplicate-* rules.
Also, this adds the type definition for the normalize-selector package.

@ybiquitous
Refactor to improve types for no-duplicate-* rules
a53139e 
This change removes `// @ts-nocheck` from the `no-duplicate-*` rules.
Also, this adds the type definition for the `normalize-selector` package.
@ybiquitous ybiquitous mentioned this pull request Sep 17, 2021
Closed
jeddy3
jeddy3 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ybiquitous
Copy link
Member Author

Thanks for the review! 😄

@ybiquitous ybiquitous merged commit 6f6353b into v14 Sep 17, 2021
@ybiquitous ybiquitous deleted the refactor-types-for-no-duplicate-rules branch September 17, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3