Plan v5 Release

[bmish]

Planned changes for v5

• Drop Node 12 and 17 support #2669
• Lint embedded templates by default #2606
• Update configs:
  • Enabled additional recommended rules no-aria-unsupported-elements, no-array-prototype-extensions, no-invalid-aria-attributes, no-obscure-array-access, no-scope-outside-table-headings, no-unsupported-role-attributes, require-aria-activedescendant-tabindex, require-mandatory-role-attributes, require-media-caption #2671
  • Replace 3-x-recommended config with 4-x-recommended #2679
  • DONE: Confirm that a11y and stylistic configs are up-to-date
• Rename rules
  • Rename and narrow rule no-down-event-binding to no-pointer-down-event-binding #2054
  • Rename no-redundant-landmark-role rule to no-redundant-role and change checkAllHTMLElements option default to true #2675
• Adjust rule option defaults
  • Change validateValues option default to true in require-lang-attribute rule #2674
  • Change maxHelpers option default to 1 in simple-unless rule #2672
  • Change simplifyHelpers option default to true in no-negated-condition rule #2673
  • Include modifiers in no-restricted-invocations rule #2657
• Update dependencies
  • Refresh lockfile from scratch #2676
  • Update eslint-plugin-unicorn to v44 and sort-package-json to v2 #2677
  • build(deps): Bump chalk from 4.1.2 to 5.1.2 #2641
  • Update jest to v29 #2680
• Support ember-template-lint v5 ember-template-lint-plugin-prettier#236
• TODO: let us know if you want to include any other breaking changes

Done already?

• Fix serious monorepo plugin / Windows issues: https://discord.com/channels/480462759797063690/666416704418611233/949340263485177866

Future changes not yet ready:

• Match ESLint behavior
  • Allow any file extension to be matched in globs to match ESLint's behavior
  • Print out full paths by default (variation of Add Option to Print Full File Paths #2491 (comment))
  • check for svg to extend the supportedExtensions #2366
• Add more rules to stylistic config
  • Add new rule attribute-order #2575 (this rule might be too noisy/opinionated to include)
• New recommended rules
  • @runspired requested to have no-model-argument-in-route-templates considered as a recommended rule but the rule and Ember documentation may need tweaks before this would make sense
• Re-evaluate whether we should be publicly-exporting so many helpers in our Node API

Follow-up tasks:

• Add ember-template-lint v5 release to Issue 205 ember-learn/ember-blog#1236
• chore(deps): update to ember-template-lint v5 in blueprint ember-cli/ember-cli#10080

For reference, v4.0.0 was released 2022-01-05, discussion in #1908.

v5 Preparation PR: #2670

Pre-release versions:

• https://github.com/ember-template-lint/ember-template-lint/releases/tag/v5.0.0-alpha.0

[NullVoxPopuli]

when are you wanting to release v5?

[bmish]

Mid-2022 so we can drop support for Node versions that will end-of-life around then, assuming we have enough breaking changes compiled.

[scalvert]

I've dropped Node 12 support in my PR unifying the bin testing infra (#2437). It's required, since the bin-tester package requires Node 14+. We can merge it into a next branch if we want, but I'm concerned that it'll be hard to merge with master once we're ready to release.

[bmish]

I would prefer we have a separate PR for each breaking change. That way, we have smaller, simpler PRs and each change will show up nicely as a separate item in the changelog. I think the next branch could be appropriate to begin if you'd like to.

[scalvert]

I would also prefer this and am happy to port the change to a separate PR. We should definitely update next with master to start pulling in changes for v5.

[bmish]

I would like to start preparing for this release soon. Any other breaking changes we should include? The current list has some straightforward rule / config changes but also some more complex behavior changes that need to be implemented.

[NullVoxPopuli]

can we include #2601 ?

gts/gjs is already very easy to use in apps / v1 addons, and it'd be great if we got linting enabled by default
we'd probably also want to recommend disabling some rules for tests/**/* -- which ELS already checks, but the CLI doesn't (but this change would enable the CLI to check tests).

Tests can use <template>, just like everywhere else, I have examples of this here: https://github.com/NullVoxPopuli/ember-resources/blob/main/testing/ember-app/tests/core/rendering-test.gts
and when linting those, it also makes sense to lint hbs backticks, which I believe is the proposal

[bmish]

First alpha release of v5 published! Please test it out and let us know if you want to include additional breaking changes before the final release in a week or two

https://github.com/ember-template-lint/ember-template-lint/releases/tag/v5.0.0-alpha.0

[bmish]

Status:

• Waiting for Ensure --fix works properly for .gjs/.gts files #2696 to be completed (CC: @gabrielcsapo @rwjblue) so I can release a final v4 version with that fix
• After that is done, will release 5.0.0

[rwjblue]

@bmish just landed #2696 thanks for pinging!

[bmish]

Release completed: https://github.com/ember-template-lint/ember-template-lint/releases/tag/v5.0.0