Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize new contents data from ember-template-imports #2658

Conversation

gabrielcsapo
Copy link
Contributor

Summary

in ember-template-imports/ember-template-imports#74 we added the ability to get the contents from the parsed template code so we can utilize that instead of slicing data.

@gabrielcsapo
Copy link
Contributor Author

@rwjblue i can update the CI version to the right version for 14 so tests can pass, so you want me to do that in this PR or another one and rebase after that is merged?

@rwjblue
Copy link
Member

rwjblue commented Oct 25, 2022

Ya, lets throw a second PR up for bumping the min 14 version

@bmish
Copy link
Member

bmish commented Oct 26, 2022

Yeah, a separate PR for dropping old Node versions would be good. We have a big major release planned in #2319. Would like to get this out soon.

@bmish
Copy link
Member

bmish commented Nov 3, 2022

Is this a breaking change? If so, let's include it in the upcoming v5 release (#2319). Note that we already dropped Node 12/17 support in the next branch.

@rwjblue
Copy link
Member

rwjblue commented Nov 8, 2022

Is this a breaking change?

Nope! Just some nice API improvements by recent ember-template-imports releases.

@bmish
Copy link
Member

bmish commented Nov 8, 2022

Okay, well it depends on Node 12/17 being dropped right? So let's re-target to next and merge it.

@rwjblue
Copy link
Member

rwjblue commented Nov 9, 2022

well it depends on Node 12/17 being dropped right?

Nope! The comments RE: Node 12 were addressed by #2659 (eslint-plugin-import-helpers added an engines config that excluded Node 12, but since CI was generally red anyways we didn't catch it before merging the original PR updating it).

@rwjblue rwjblue merged commit 75d91d8 into ember-template-lint:master Nov 9, 2022
@bmish bmish changed the title feat: utilize new contents data from ember-template-imports Utilize new contents data from ember-template-imports Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants