Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-negated-condition rule could detect (not (not ...)) #2644

Closed
bmish opened this issue Oct 17, 2022 · 0 comments · Fixed by #2653
Closed

no-negated-condition rule could detect (not (not ...)) #2644

bmish opened this issue Oct 17, 2022 · 0 comments · Fixed by #2653
Labels
breaking
Milestone
5.0.0

Comments

@bmish
Copy link
Member

bmish commented Oct 17, 2022 •
edited

However, I think this should also be a new violation detected and autofixed by no-negated-condition (in the next major release since adding new new violations to existing rules is a breaking change). If interested, you could open a PR for that.

Originally posted by @bmish in #2639 (comment)

Would need to be part of a major release (#2319).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add simplifyHelpers option in no-negated-condition rule godric3/ember-template-lint
1 participant
@bmish