Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ember-template-lint v5 release to Issue 205 #1236

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add ember-template-lint v5 release to Issue 205 #1236

merged 1 commit into from
Nov 22, 2022

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Nov 19, 2022 •
edited

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Announce major version release of ember-template-lint. Similar to announcements of previous major versions.

CC: @NullVoxPopuli

Related Issue(s)

ember-template-lint/ember-template-lint#2319

https://github.com/ember-template-lint/ember-template-lint/releases/tag/v5.0.0

Sources

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Nov 19, 2022
@bmish bmish mentioned this pull request Nov 19, 2022
Closed
@bmish bmish marked this pull request as ready for review November 19, 2022 18:35
@bmish bmish requested a review from a team as a code owner November 19, 2022 18:35
MinThaMie
MinThaMie approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the write up :)

@MinThaMie MinThaMie merged commit 97dd407 into ember-learn:blog/embertimes-205 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinThaMie MinThaMie MinThaMie approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmish @MinThaMie