Add checkAllHTMLElements
option to no-redundant-landmark-role
rule to lint against all HTML elements with default ARIA roles
#2487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2485.
Background
Most HTML elements have default/implicit ARIA roles, and setting a role that matches an element's default has no effect.
This PR adds an option,
checkAllElementRoles
, in the config for the existingno-redundant-landmark-role
rule to expand its coverage to lint against all HTML elements with default roles.This PR also adds the
nav
element and thenavigation
role to the list of allowed element-role pairings, as advised by the W3 for accessibility, and thefooter
element andcontentinfo
role are removed due to redundancy in their functions.References:
no-redundant-roles
ruleAllowed:
Forbidden:
Testing
Tests: 5 skipped, 7545 passed, 7550 total
Snapshots: 990 passed, 990 total
Time: 139.005 s, estimated 159 s
Ran all test suites.
✨ Done in 152.69s.