Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint embedded templates by default #2606

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Sep 1, 2022

Fixes #2601

Support for embedded templates is now enabled by default in js, ts, gjs, and gts files

Part of v5 release (#2319).

@NullVoxPopuli NullVoxPopuli changed the title Support embedded linting by default [Breaking, v5] Support embedded linting by default Sep 1, 2022
@bmish
Copy link
Member

bmish commented Sep 1, 2022

Just FYI you need to use the syntax "Fixes #000" so that the PR will automatically resolve the issue when merged.

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review September 2, 2022 00:06
@NullVoxPopuli
Copy link
Contributor Author

Idk what's up with node 18

@bmish
Copy link
Member

bmish commented Sep 2, 2022

Ignore Node 18 CI. Preexisting issue.

@bmish bmish added the breaking label Sep 2, 2022
@bmish
Copy link
Member

bmish commented Sep 2, 2022

Just FYI you need to use the syntax "Fixes #000" so that the PR will automatically resolve the issue when merged.

This needs to be in the PR description.

@NullVoxPopuli
Copy link
Contributor Author

done, thanks!

@bmish bmish changed the base branch from master to next November 3, 2022 14:28
@bmish bmish changed the title [Breaking, v5] Support embedded linting by default Lint embedded templates by default Nov 3, 2022
@bmish bmish merged commit b57e8e4 into ember-template-lint:next Nov 3, 2022
@bmish bmish mentioned this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check embedded templates by default
2 participants