Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change maxHelpers default for simple-unless rule? #2645

Closed
bmish opened this issue Oct 17, 2022 · 0 comments
Closed

Change maxHelpers default for simple-unless rule? #2645

bmish opened this issue Oct 17, 2022 · 0 comments
Labels
Milestone

Comments

@bmish
Copy link
Member

bmish commented Oct 17, 2022

I was never too big of a fan of how this simple-unless rules disallows helpers with unless entirely. In many of my codebases at work, we have disabled the helpers check with 'simple-unless': { maxHelpers: -1 }. Might be worth re-evaluating the default for this in a major release (v5 #2319). Even allowing just 1 helper by default would help a lot.

This is especially relevant now that we added an autofixer for this in #2639. Autofixing unless to if not just because a helper is present doesn't feel like much of an improvement and is kind of annoying.

Originally posted by @bmish in #2639 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant