Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure --fix works properly for .gjs/.gts files #2696

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Ensure --fix works properly for .gjs/.gts files #2696

merged 2 commits into from
Nov 17, 2022

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Nov 8, 2022 •
edited

Fix #2681

@rwjblue rwjblue added the bug label Nov 8, 2022
@rwjblue rwjblue mentioned this pull request Nov 8, 2022
Closed
@gabrielcsapo
Copy link
Contributor

Looking at this now.

@gabrielcsapo gabrielcsapo mentioned this pull request Nov 9, 2022
Merged
@gabrielcsapo gabrielcsapo mentioned this pull request Nov 9, 2022
Merged
rwjblue
rwjblue commented Nov 10, 2022
View reviewed changes
lib/helpers/rule-test-harness.js Outdated Show resolved Hide resolved
lib/linter.js Outdated Show resolved Hide resolved
lib/linter.js Outdated Show resolved Hide resolved
lib/linter.js Outdated Show resolved Hide resolved
test/unit/rules/require-button-type-test.js Outdated Show resolved Hide resolved
rwjblue and others added 2 commits November 14, 2022 14:37
@rwjblue @gabrielcsapo
Failing test cases for --fix with .gjs/.gts files
1cfcf84 
Co-authored-by: Gabriel Csapo <gabecsapo@gmail.com>
@gabrielcsapo @rwjblue
fix: Ensure --fix works for .gjs/.gts files
f5abdf0 
Co-authored-by: Robert Jackson <me@rwjblue.com>
@rwjblue rwjblue changed the title Failing test cases for --fix with .gjs/.gts files Ensure--fix works properly for .gjs/.gts files Nov 14, 2022
@bmish bmish mentioned this pull request Nov 15, 2022
Closed
@bmish
Copy link
Member

bmish commented Nov 17, 2022 •
edited

Just wondering, how close is this to being ready? Per this comment, the plan is to release a final v4 version with this fix and then release v5.

@gabrielcsapo
Copy link
Contributor

@bmish should be good to go, just need to double check with @rwjblue if he is ready to have it moved from draft state.

@rwjblue rwjblue marked this pull request as ready for review November 17, 2022 21:07
@rwjblue rwjblue merged commit a691006 into master Nov 17, 2022
@rwjblue rwjblue deleted the reproduce-gts-fix-issue branch November 17, 2022 21:08
@bmish bmish changed the title Ensure--fix works properly for .gjs/.gts files Ensure --fix works properly for .gjs/.gts files Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--fix is broken with .gts files
3 participants
@rwjblue @gabrielcsapo @bmish