Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ember-template-lint v5 #236

Closed
bmish opened this issue Nov 3, 2022 · 3 comments · Fixed by #237
Closed

Support ember-template-lint v5 #236

bmish opened this issue Nov 3, 2022 · 3 comments · Fixed by #237
Labels
enhancement New feature or request

Comments

@bmish
Copy link
Member

bmish commented Nov 3, 2022

ember-template-lint v5 is out:

The work is being tracked in: ember-template-lint/ember-template-lint#2319

@bertdeblock
Copy link
Collaborator

Do we want a release that supports both ember-template-lint v4 and v5?
Unrelated, it seems we could also update the supported Node engines:
https://github.com/ember-template-lint/ember-template-lint-plugin-prettier/blob/main/package.json#L54.

@bmish
Copy link
Member Author

bmish commented Nov 4, 2022

Yes, I don't see why this plugin needs to be limited to a single major version of ember-template-lint. I think we can change the peer dependency to "ember-template-lint": ">= 4.0.0" as v4 and all subsequent versions will be ESM and unlikely to have compatibility issues.

@bmish
Copy link
Member Author

bmish commented Nov 24, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants