no-restricted-invocations doesn't support modifiers

[achambers]

I noticed today that the no-restricted-invocations rule doesn't support modifiers and it feels like it should.

Seems like it'd just take adding ElementModifierStatement to

ember-template-lint/lib/rules/no-restricted-invocations.js

Lines 78 to 83 in 9e99852

	return {
	BlockStatement: checkDenylist,
	ElementNode: checkDenylist,
	MustacheStatement: checkDenylist,
	SubExpression: checkDenylist,
	};

Let me know if this is an improvement to the rule that you support. I've knocked together a short PR to implement it - #2657

[bmish]

Seems reasonable. As is, it's a breaking change that would need to go in with #2319.

[achambers]

Seems reasonable. As is, it's a breaking change that would need to go in with #2319.

Coolio. Anything you need from me to make this so?

[bmish]

If you wanted to get it in sooner and also reduce risk, you could put this functionality behind an option (e.g. includeModifiers or something) and then we could just enable the option during the major release. But since it's not that big, it could also just go in during the major release as-is (whenever that happens).

[rwjblue]

I totally agree that its breaking, but I also think that we could consider it a bug fix. In other words, it seems pretty clear that this is a bug (we probably should have always considered modifiers here, but when the rule was written modifiers didn't exist), and semver clearly allows for the conceptual space of "breaking bugfixes".