Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint from 5.7.0 to 5.9.0 #320

Merged
merged 2 commits into from Nov 17, 2018
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 16, 2018

Bumps eslint from 5.7.0 to 5.9.0.

Release notes

Sourced from eslint's releases.

v5.9.0

  • 9436712 Fix: Unused recursive function expressions (fixes #10982) (#11032) (Sergei Startsev)
  • c832cd5 Update: add ignoreDestructuring option to id-match rule (#10554) (一名宅。)
  • 54687a8 Fix: prefer-const autofix multiline assignment (fixes #10582) (#10987) (Scott Stern)
  • ae2b61d Update: "off" options for "space-before-blocks" (refs #10906) (#10907) (Sophie Kirschner)
  • 57f357e Docs: Update require-await docs with exception (fixes #9540) (#11063) (Nicholas C. Zakas)
  • 79a27976 Update: no-restricted-imports to check re-export (fixes #9678) (#11064) (Nicholas C. Zakas)
  • 3dd7493 Docs: update ecmaVersion to include 2019/10 values (#11059) (Vse Mozhet Byt)
  • 607635d Upgrade: eslint-plugin-node & eslint-plugin (#11067) (薛定谔的猫)
  • dcc6233 Fix: Ignore empty statements in no-unreachable (fixes #9081) (#11058) (Nicholas C. Zakas)
  • 7ad86de New: Add --fix-type option to CLI (fixes #10855) (#10912) (Nicholas C. Zakas)
  • 0800b20 Chore: fix invalid super() calls in tests (#11054) (Teddy Katz)
  • 4fe3287 Docs: Cross-reference two rules (refs #11041) (#11042) (Paul Melnikow)
  • 5525eb6 Fix: rule deprecation warnings did not consider all rules (#11044) (Teddy Katz)
  • 44d37ca Docs: Update steps for adding new TSC member (#11038) (Nicholas C. Zakas)
  • 802e926 Update: Warn for deprecation in Node output (fixes #7443) (#10953) (Colin Chang)

v5.8.0

  • 9152417 Fix: deprecation warning in RuleTester using Node v11 (#11009) (Teddy Katz)
  • e349a03 Docs: Update issue templates to ask for PRs (#11012) (Nicholas C. Zakas)
  • 3d88b38 Chore: avoid using legacy report API in no-irregular-whitespace (#11013) (Teddy Katz)
  • 5a31a92 Build: compile espree's deps to ES5 when generating site (fixes #11014) (#11015) (Teddy Katz)
  • 3943635 Update: Create Linter.version API (fixes #9271) (#11010) (Nicholas C. Zakas)
  • a940cf4 Docs: Mention version for config glob patterns (fixes #8793) (Nicholas C. Zakas)
  • 6e1c530 Build: run tests on Node 11 (#11008) (Teddy Katz)
  • 58ff359 Docs: add instructions for npm 2FA (refs #10631) (#10992) (Teddy Katz)
  • 2f87bb3 Upgrade: eslint-release@1.0.0 (refs #10631) (#10991) (Teddy Katz)
  • 57ef0fd Fix: prefer-const when using destructuring assign (fixes #8308) (#10924) (Nicholas C. Zakas)
  • 577cbf1 Chore: Add typescript-specific edge case tests to space-infix-ops (#10986) (Bence Dányi)
  • d45b184 Chore: Using deconstruction assignment for shelljs (#10974) (ZYSzys)
Changelog

Sourced from eslint's changelog.

v5.9.0 - November 9, 2018

  • 9436712 Fix: Unused recursive function expressions (fixes #10982) (#11032) (Sergei Startsev)
  • c832cd5 Update: add ignoreDestructuring option to id-match rule (#10554) (一名宅。)
  • 54687a8 Fix: prefer-const autofix multiline assignment (fixes #10582) (#10987) (Scott Stern)
  • ae2b61d Update: "off" options for "space-before-blocks" (refs #10906) (#10907) (Sophie Kirschner)
  • 57f357e Docs: Update require-await docs with exception (fixes #9540) (#11063) (Nicholas C. Zakas)
  • 79a2797 Update: no-restricted-imports to check re-export (fixes #9678) (#11064) (Nicholas C. Zakas)
  • 3dd7493 Docs: update ecmaVersion to include 2019/10 values (#11059) (Vse Mozhet Byt)
  • 607635d Upgrade: eslint-plugin-node & eslint-plugin (#11067) (薛定谔的猫)
  • dcc6233 Fix: Ignore empty statements in no-unreachable (fixes #9081) (#11058) (Nicholas C. Zakas)
  • 7ad86de New: Add --fix-type option to CLI (fixes #10855) (#10912) (Nicholas C. Zakas)
  • 0800b20 Chore: fix invalid super() calls in tests (#11054) (Teddy Katz)
  • 4fe3287 Docs: Cross-reference two rules (refs #11041) (#11042) (Paul Melnikow)
  • 5525eb6 Fix: rule deprecation warnings did not consider all rules (#11044) (Teddy Katz)
  • 44d37ca Docs: Update steps for adding new TSC member (#11038) (Nicholas C. Zakas)
  • 802e926 Update: Warn for deprecation in Node output (fixes #7443) (#10953) (Colin Chang)

v5.8.0 - October 26, 2018

  • 9152417 Fix: deprecation warning in RuleTester using Node v11 (#11009) (Teddy Katz)
  • e349a03 Docs: Update issue templates to ask for PRs (#11012) (Nicholas C. Zakas)
  • 3d88b38 Chore: avoid using legacy report API in no-irregular-whitespace (#11013) (Teddy Katz)
  • 5a31a92 Build: compile espree's deps to ES5 when generating site (fixes #11014) (#11015) (Teddy Katz)
  • 3943635 Update: Create Linter.version API (fixes #9271) (#11010) (Nicholas C. Zakas)
  • a940cf4 Docs: Mention version for config glob patterns (fixes #8793) (Nicholas C. Zakas)
  • 6e1c530 Build: run tests on Node 11 (#11008) (Teddy Katz)
  • 58ff359 Docs: add instructions for npm 2FA (refs #10631) (#10992) (Teddy Katz)
  • 2f87bb3 Upgrade: eslint-release@1.0.0 (refs #10631) (#10991) (Teddy Katz)
  • 57ef0fd Fix: prefer-const when using destructuring assign (fixes #8308) (#10924) (Nicholas C. Zakas)
  • 577cbf1 Chore: Add typescript-specific edge case tests to space-infix-ops (#10986) (Bence Dányi)
  • d45b184 Chore: Using deconstruction assignment for shelljs (#10974) (ZYSzys)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [eslint](https://github.com/eslint/eslint) from 5.7.0 to 5.9.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v5.7.0...v5.9.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/eslint-5.9.0 branch from 814bf2d to de33cfd Compare November 17, 2018 00:05
@Mr0grog
Copy link
Member

Mr0grog commented Nov 17, 2018

Ugh. Investigating this failure just makes me wish we hadn’t switched from Yarn to NPM :(

The failures here are actually a dependency resolution problem in NPM. There’s an ESLint tracking bug here: eslint/eslint#11018 and an NPM bug here: https://npm.community/t/failed-to-install-eslint-in-a-specific-situation/2975

I can fix it by blowing away package-lock.json and completely regenerating it, which is super 👎, but it’s what I’m gonna do here because NPM is just breaking otherwise.

Due to a dependency resolution problem in NPM, some of our packages are no longer installing correctly. Blowing away the lockfile and installing everything fresh solves the issue, at the cost of an uncontrolled update of all our dependencies. Things seem to be working alright, though.
@Mr0grog
Copy link
Member

Mr0grog commented Nov 17, 2018

We’ll see if this is successful in CI.

@Mr0grog Mr0grog merged commit facde3d into master Nov 17, 2018
@Mr0grog Mr0grog deleted the dependabot/npm_and_yarn/eslint-5.9.0 branch November 17, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants