no-restricted-imports doesn't handle re-export

[asapach]

• ESLint Version: 4.12.1

{
    "parserOptions": {
        "ecmaVersion": 6,
        "sourceType": "module"
    },
    "rules": {
        "no-restricted-imports": ["error", "fs"]
    }
}

import fs from 'fs';
export * from 'fs';
export {default as fs} from 'fs';
export {readFile} from 'fs';

What did you expect to happen?
All the statements including re-exports should be reported as errors.

What actually happened? Please include the actual, raw output from ESLint.

  1:1  error  'fs' import is restricted from being used  no-restricted-imports

Only import is reported; re-exports are ignored.

[ilyavolodin]

The rule is supposed to only check import statements, so I'm not sure why would it report an export.

[j-f1]

This is because the export ... from 'module' is not yet part of JavaScript, and ESLint doesn’t support features that are still proposals. This would be a good rule suggestion for eslint-plugin-babel, though. This is incorrect; see below.

[asapach]

@ilyavolodin, Because a re-export is essentially an import + export. So export {readFile} from 'fs' is equivalent to:

import {readFile} from 'fs';
export {readFile};

By ignoring re-exports you are leaving an escape hatch for no-restricted-imports, so people can re-export forbidden modules and import them elsewhere.

@j-f1 I'm talking about ES2015 syntax; future proposals are out of scope.

[j-f1]

@asapach I’m trying to say that everything but the first line in your initial code sample is not part of ES2015, ES2016, or ES2017. It’s currently a stage 1 proposal (export v from "mod"; statements). Therefore, it’s out-of-scope for ESLint.

ES2015 only supports this:

import foo from 'bar'
import { foo, bar as baz } from 'quux'

export const /* or let/var */ foo = 2
export {
  foo as bar,
  baz
}
export default foo

However, I would be interested in seeing this checked by eslint-plugin-babel.

This is incorrect; see below.

[asapach]

@j-f1, tell that to @nzakas:

• http://2ality.com/2014/09/es6-modules-final.html#re-exporting
• http://exploringjs.com/es6/ch_modules.html#_re-exporting

[asapach]

@j-f1 the proposal is specifically about a more convenient syntax for re-exporting default and has nothing to do with this issue.

[j-f1]

🤦‍♂️ sorry. Thanks for sharing that with me! I must’ve misread the proposals I linked to. I’ll take a look at this and see if I can fix it.

Notes to self: rule source, copy-paste[?] ImportDeclaration to "ExportAllDeclaration, ExportNamedDeclaration". ExportAll -> isRestrictedForEverythingImported, ExportNamed -> isRestrictedPath

[not-an-aardvark]

@j-f1 There's no rush, but have you gotten a chance to take a look at this?

[j-f1]

I have not gotten a chance to look at this yet.

[nzakas]

I'll look at this.

[ljharb]

Linking to #11064.