Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update issue templates to ask for PRs #11012

Merged
merged 2 commits into from Oct 25, 2018
Merged

Docs: Update issue templates to ask for PRs #11012

merged 2 commits into from Oct 25, 2018

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Oct 24, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added a question to each issue template asking if the person creating the issue is willing to implement the change they are requesting. I thought at one point we had this, and I think it's a good way to nudge people into contributing rather than just expecting that someone else will implement the suggestion.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 24, 2018
@not-an-aardvark
Copy link
Member

Bikeshed: Could we reword this to something like "Would you be willing to submit a pull request" rather than "Will you submit a pull request"? It seems like the current wording might be interpreted as a request that someone work on a PR as soon as they create the issue, without waiting for feedback. People often report intended behavior as a bug if they misunderstand how it's supposed to work, and in those cases I wouldn't want them to preemptively spend their time on a PR only to be told later that the current behavior is correct.

@nzakas
Copy link
Member Author

nzakas commented Oct 24, 2018

Fair point. I'd prefer to use "Are you willing..." instead of "Would you be willing..." as the latter is a bit more passive than I'm comfortable with. I'll make that change.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Nitpick: There is an inconsistent number of blank lines following the new question across the templates. But that's not a blocker.

@platinumazure platinumazure added documentation Relates to ESLint's documentation infrastructure Relates to the tools used in the ESLint development process and removed triage An ESLint team member will look at this issue soon labels Oct 24, 2018
@nzakas nzakas merged commit e349a03 into master Oct 25, 2018
@nzakas nzakas deleted the templates branch October 25, 2018 20:08
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 24, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants