Fix: rule deprecation warnings did not consider all rules #11044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
N/A
Please show your full configuration:
N/A
What did you do? Please include the actual source code causing the issue.
From within the ESLint repository:
Ran
eslint Makefile.js --format json
in the ESLint repositoryWhat did you expect to happen?
I expected the output to contain a
usedDeprecatedRules
property indicating that theno-catch-shadow
rule (which we enable ineslint-config-eslint
) has been replaced byno-shadow
.What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
This fixes a bug where rule deprecation warnings would only be generated for rules passed via the
--rule
flag on the command line, rather for all rules configured in a config file. It also addresses an issue where passing a nonexistent rule on the command line would cause CLIEngine to crash, which broke the eslint-canary build.Additionally,
usedDeprecatedRules
was only appearing on the result ofCLIEngine#executeOnFiles
before. I updated it to also appear on the result ofCLIEngine#executeOnText
, since the two functions are documented to have the same output format.Is there anything you'd like reviewers to focus on?
Nothing in particular