Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update require-await docs with exception (fixes #9540) #11063

Merged
merged 3 commits into from Nov 9, 2018
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated the docs for require-await to explain why you might not want to use it. Also, expanded the rule's description. It seems like this rule really needed a lot more documentation than it had.

Is there anything you'd like reviewers to focus on?

Does everything make sense?

@nzakas nzakas added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation labels Nov 7, 2018
@aladdin-add aladdin-add closed this Nov 8, 2018
@aladdin-add aladdin-add reopened this Nov 8, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos, otherwise LGTM. Thanks!

docs/rules/require-await.md Outdated Show resolved Hide resolved
docs/rules/require-await.md Outdated Show resolved Hide resolved
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last typo, then LGTM 👍

docs/rules/require-await.md Outdated Show resolved Hide resolved
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 57f357e into master Nov 9, 2018
@nzakas nzakas deleted the issue9540 branch November 9, 2018 18:11
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 9, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants