Chore: avoid using legacy report API in no-irregular-whitespace #11013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Oct 24, 2018
gyandeeps
approved these changes
Oct 24, 2018
This updates the no-irregular-whitespace rule to avoid using the legacy multi-argument `context.report` API. We have a linting rule to enforce against using the API, but the rule wasn't enforcing it in this case. This was originally found by Aladdin-ADD in eslint-community/eslint-plugin-eslint-plugin#64.
not-an-aardvark
force-pushed
the
no-use-legacy-report-api
branch
from
6c6a5fd
to
6dc4eda
Compare
platinumazure
approved these changes
Oct 24, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This updates the no-irregular-whitespace rule to avoid using the legacy multi-argument
context.reportAPI. We have a linting rule to enforce against using the API, but the rule wasn't enforcing it in this case.This was originally found by @aladdin-add in eslint-community/eslint-plugin-eslint-plugin#64.
Is there anything you'd like reviewers to focus on?
Nothing in particular