Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add instructions for npm 2FA (refs #10631) #10992

Merged
merged 1 commit into from Oct 19, 2018

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Oct 17, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

(refs #10631)

This adds a page to the maintainer guide describing how to get access to the npm 2FA secret for the eslint account. It also updates the release guidelines to account for the 2FA step.

Is there anything you'd like reviewers to focus on?

If you're on the TSC and you haven't set up Keybase yet, it might be useful to use these instructions to get set up, and point out any issues you encounter with the instructions.

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Oct 17, 2018
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this all up!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the instructions were very clear. Thanks!

@not-an-aardvark not-an-aardvark merged commit 58ff359 into master Oct 19, 2018
@not-an-aardvark not-an-aardvark deleted the update-2fa-instructions branch October 19, 2018 04:54
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 18, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants