Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Create Linter.version API (fixes #9271) #11010

Merged
merged 1 commit into from Oct 24, 2018
Merged

Update: Create Linter.version API (fixes #9271) #11010

merged 1 commit into from Oct 24, 2018

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Oct 23, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added Linter.version. I used a getter because JavaScript doesn't yet have static class properties, and otherwise, I'd need to do some hacky thing to add a property to the Linter constructor. I think this makes sense since Linter.version should not be overwritten.

Is there anything you'd like reviewers to focus on?

Is this what was expected?

@nzakas nzakas added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features labels Oct 23, 2018
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nzakas nzakas merged commit 3943635 into master Oct 24, 2018
@nzakas nzakas deleted the issue9271 branch October 24, 2018 16:23
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 23, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants