Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump faker from 1.9.3 to 1.9.4 #509

Merged
merged 2 commits into from Jun 23, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps faker from 1.9.3 to 1.9.4.

Release notes

Sourced from faker's releases.

v1.9.4

v1.9.4 (2019-06-19)

Bug/Fixes

Chores

Deprecation

Documentation

Feature Request

Update/add locales

... (truncated)
Changelog

Sourced from faker's changelog.

v1.9.4 (2019-06-19)

Bug/Fixes

Chores

Deprecation

Documentation

Feature Request

Update/add locales

... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Bumps [faker](https://github.com/stympy/faker) from 1.9.3 to 1.9.4.
- [Release notes](https://github.com/stympy/faker/releases)
- [Changelog](https://github.com/stympy/faker/blob/master/CHANGELOG.md)
- [Commits](faker-ruby/faker@v1.9.3...1.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jun 20, 2019
@jasnow
Copy link

jasnow commented Jun 23, 2019

Here is a workaround to line 29 of db/seeds/games.rb based on faker-ruby/faker#1638

From:
    name: Faker::Game.unique.name,
To:
    name: Faker::Game.name + Faker::Number.number(10),

@connorshea
Copy link
Owner

I think this may actually be because I PR'd my games generator into Faker and that was released with 1.9.4. faker-ruby/faker#1607

It's probably a better fix to remove my custom faker generators and use the ones provided by Faker itself.

@jasnow
Copy link

jasnow commented Jun 23, 2019

OK

They're now provided by the upstream Faker project.
@connorshea connorshea force-pushed the dependabot/bundler/master/faker-1.9.4 branch from 185f497 to 495f8d3 Compare June 23, 2019 20:34
@connorshea connorshea merged commit 63fe7aa into master Jun 23, 2019
@connorshea connorshea deleted the dependabot/bundler/master/faker-1.9.4 branch June 23, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants