Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sic_code to company #355 #1540

Merged
merged 2 commits into from Feb 15, 2019
Merged

Add sic_code to company #355 #1540

merged 2 commits into from Feb 15, 2019

Conversation

bruno-b-martins
Copy link
Contributor

Hey guys,

I'm addressing this very old issue: #355

I don't know nearly anything about sic_codes so I took them from this list: https://github.com/saintsjd/sic4-list/blob/master/sic-codes.csv

Feel free to contact me :-)

Thanks

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation doc/unreleased/company.md and describe your changes.

@bruno-b-martins
Copy link
Contributor Author

Thanks for reminding me @vbrazo.

Please, let me know if there's anything else missing.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@vbrazo vbrazo merged commit b3cc465 into faker-ruby:master Feb 15, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add sic_code to company

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants