Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker::Movies::GratefulDead => Faker::Music::GratefulDead #1549

Merged
merged 1 commit into from Feb 23, 2019

Conversation

bcharna
Copy link
Contributor

@bcharna bcharna commented Feb 22, 2019

Grateful Dead is music, not a movie 😄

@@ -259,6 +259,7 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master'

### Music
- [Faker::Music](doc/unreleased/music/music.md)
- [Faker::Music::GratefulDead](doc/music/grateful_dead.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also remove the entry under Movies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@vbrazo vbrazo merged commit 7431995 into faker-ruby:master Feb 23, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants