Add new categories to armenian #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Feb 16, 2019
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* fix warning: character class has '-' without escape * fix the name of constellation Leo * remove duplicate ingredient names * add Artist, Book, Food, Military, Science, Space categories to armenian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been made:
fix warning: character class has '-' without escape
since '-' has special meaning in regex then it should be escaped or it should be at the start of the class. (or at the end of the class)
fix the name of constellation Leo
it was spelled as 'Loe'
remove duplicate ingredient names
Cherries, Chestnut, Garlic, Lychees and Mackerel had duplicate entries
add Artist, Book, Food, Military, Science, Space categories to armenian