Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name_with_middle field for en-AU #1559

Merged
merged 1 commit into from Mar 2, 2019
Merged

Conversation

psibi
Copy link
Member

@psibi psibi commented Mar 2, 2019

The name_with_middle should be under the name field.

@stympy
Copy link
Contributor

stympy commented Mar 2, 2019

This isn’t right... name_with_middle is a sibling to name, not a child.

@stympy stympy closed this Mar 2, 2019
@psibi
Copy link
Member Author

psibi commented Mar 2, 2019

@stympy That's not the case with other files. Example files I found it opposite:

  • en-PAK.yml
  • ee.yml
  • en/name.yml

to name a few..

@stympy
Copy link
Contributor

stympy commented Mar 2, 2019

Are we looking at the same thing?

$ irb -ryaml
> YAML.load_file('lib/locales/en/name.yml')['en']['faker']['name'].keys
=> ["male_first_name", "female_first_name", "first_name", "last_name", "prefix", "suffix", "name", "name_with_middle"]

@psibi
Copy link
Member Author

psibi commented Mar 2, 2019

@stympy Let's take the ee.yml file: https://github.com/stympy/faker/blob/master/lib/locales/ee.yml#L42

You can see that name_with_middle is child of name there.

@stympy
Copy link
Contributor

stympy commented Mar 2, 2019

Ah, looking at it again, I see I misunderstood the context of the change. Yes, line 10 should be changed as in the patch, but line 11 should not be.

@stympy stympy reopened this Mar 2, 2019
@psibi
Copy link
Member Author

psibi commented Mar 2, 2019

@stympy Reg line 11, yeah you're right. But according to YAML specification - that should also work. But I can change that if you would prefer not changing that.

@stympy
Copy link
Contributor

stympy commented Mar 2, 2019

Yeah, it would work, but it doesn't match the existing style. Please revert line 11 and this will be good to go. Thanks!

@psibi
Copy link
Member Author

psibi commented Mar 2, 2019

@stympy Pushed a new commit. I hope that works.

@stympy stympy merged commit f873bab into faker-ruby:master Mar 2, 2019
@stympy
Copy link
Contributor

stympy commented Mar 2, 2019

Perfect, thanks!

@vbrazo vbrazo added the Chores label Mar 3, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants