Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default values for optional arguments in Lorem Documentation #1636

Merged
merged 1 commit into from Jun 20, 2019

Conversation

mikong
Copy link
Contributor

@mikong mikong commented Jun 18, 2019

Fixes #1635.

I changed both doc/default/lorem.md and doc/unreleased/default/lorem.md.

Please let me know if there's anything I should change in my PR.

@vbrazo vbrazo merged commit e573973 into faker-ruby:master Jun 20, 2019
sanikkenway referenced this pull request in sanikkenway/faker Jun 21, 2019
 Fix default values for arguments in Lorem doc (stympy#1636)
@mikong mikong deleted the fix-lorem-doc branch June 21, 2019 03:48
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect default values for optional arguments in Lorem Documentation
2 participants