Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Music::Opera #1619

Merged
merged 10 commits into from Jun 6, 2019
Merged

Add Faker::Music::Opera #1619

merged 10 commits into from Jun 6, 2019

Conversation

Adsidera
Copy link
Contributor

  • run test suite successfully with bundle exec rake
  • run Rubocop successfully
  • added opera.yml in `locales/en'

Now Faker can generate a title of an opera by Rossini, Donizetti, Verdi or Bellini

@Adsidera Adsidera changed the title Added Faker for Opera Add Faker::Music::Opera May 22, 2019
@gkunwar
Copy link
Contributor

gkunwar commented May 30, 2019

@Adsidera please add documentation link to unreleased_README file so that we can update to README after release.

@Adsidera
Copy link
Contributor Author

Adsidera commented May 30, 2019

@Adsidera please add documentation link to unreleased_README file so that we can update to README after release.

@gkunwar done :)

@@ -0,0 +1,8 @@
# Faker::Music::Opera
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be inside the doc/unreleased folder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we add it to the doc folder directly, people will think it's in the current version and it's not yet

Copy link
Contributor Author

@Adsidera Adsidera Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbrazo ok! Btw, can all these informations and guidelines be added to the Contributing page as well? They are yet missing from that page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbrazo ok! Btw, can all these informations and guidelines be added to the Contributing page as well? They are yet missing from that page

Agreed :) What do you say @vbrazo and @stympy

@vbrazo vbrazo merged commit c9f6be8 into faker-ruby:master Jun 6, 2019
sanikkenway added a commit to sanikkenway/faker that referenced this pull request Jun 6, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* added tests and corrected yaml

* corrected test

* fixed missing magic comment and missing spaces

* added dashed array in yml and doc

* moved opera.md to doc/music/opera.md and added link to it in ureleased_README

* moved test_faker_opera to faker/music directory

* corrected path to test_helper in test_faker_opera.rb

* moved opera.md to doc unreleased

* restarted pr
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* added tests and corrected yaml

* corrected test

* fixed missing magic comment and missing spaces

* added dashed array in yml and doc

* moved opera.md to doc/music/opera.md and added link to it in ureleased_README

* moved test_faker_opera to faker/music directory

* corrected path to test_helper in test_faker_opera.rb

* moved opera.md to doc unreleased

* restarted pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants