Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shallow_json for frozen_string_literal #1605

Merged
merged 1 commit into from May 10, 2019
Merged

fix shallow_json for frozen_string_literal #1605

merged 1 commit into from May 10, 2019

Conversation

causztic
Copy link
Contributor

@causztic causztic commented May 6, 2019

Fixes #1598. Don't think I need to write tests for this because it's basically replacing prepend.

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@vbrazo vbrazo merged commit 76f8c76 into faker-ruby:master May 10, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faker::Json.shallow_json raises FrozenError
3 participants