Add Sports namespace #1538
Merged
Add Sports namespace #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbrazo should the unreleased README and. CHANGELOG be mentioned in the contributing guide? That way, community contributors can make those changes themselves, rather than the core maintainers doing it as a chore. |
|
I think it's a good idea, but some contributors won't change these files because they're lazy or busy. Notice that I moved |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Update unreleased/docs and move sport namespace to unreleased folder * Deprecate ::Football * Separate v1.9.3 deprecations from current version deprecaions * Update Faker::Construction documentation * Update CHANGELOG * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
::Footballv1.9.3deprecations from current version deprecationsFaker::ConstructiondocumentationTo understand more about deprecation and namespaces: #1318